Fix linting - #6420
Merged
Merged
Conversation
github-actions
Bot
added
changelog:solidus_api
AlistairNorman
force-pushed
the
fix-linting
branch
from
February 26, 2026 19:28
218b36b to
99ed261
Compare
AlistairNorman
marked this pull request as ready for review
February 26, 2026 19:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6420 +/- ##
==========================================
- Coverage 89.50% 88.80% -0.71%
==========================================
Files 981 855 -126
Lines 20476 18275 -2201
==========================================
- Hits 18327 16229 -2098
+ Misses 2149 2046 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AlistairNorman
marked this pull request as draft
February 28, 2026 08:41
Contributor
Author
|
Looks like there are still some issues. I'll sort this out next week. |
Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
This is the new config format as of eslint 10. Co-Authored-By: Adam Mueller <adam@super.gd> Co-Authored-By: Jared Norman <jared@super.gd> Co-Authored-By: Chris Todorov <chris@super.gd> Co-Authored-By: Senem Soy <senem@super.gd> Co-Authored-By: Noah Silvera <noah@super.gd>
This was failing linting. The purpose of the other parts of this case statement was to change the credit amount but this part didn't do anything.
AlistairNorman
force-pushed
the
fix-linting
branch
9 times, most recently
from
March 2, 2026 17:56
31ad0f1 to
38e03d5
Compare
remainingWidth isn't defined on this line. -= with undefined returns NaN and doesn't do anything so this can be safely deleted. The behaviour of this code seems to be correct so no other changes are needed from what I can tell.
This was found by the linter. The value is overwritten in all cases so this initial value is never used.
This is required for linting on CI. Otherwise it fails with an error that it can't find eslint.
AlistairNorman
force-pushed
the
fix-linting
branch
from
March 2, 2026 18:59
38e03d5 to
398c020
Compare
github-actions
Bot
added
the
changelog:solidus_backend
AlistairNorman
marked this pull request as ready for review
March 2, 2026 19:01
jarednorman
approved these changes
Mar 2, 2026
tvdeyen
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rubocop and eslint linting were both erroring. Running Rubocop and migrating to a new kind of config file fixed these issues.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: